🐞 Keycloak/Admin Portal: Can't publish on tenants with passkeys - #2829
Open
BelSequent wants to merge 7 commits into
Open
🐞 Keycloak/Admin Portal: Can't publish on tenants with passkeys#2829BelSequent wants to merge 7 commits into
BelSequent wants to merge 7 commits into
Conversation
This reverts commit 2fc3a90.
…"" This reverts commit 92e6ea0.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates local development configuration and Keycloak realm provisioning so tenants using passkeys can successfully complete login/redirect flows during publishing.
Changes:
- Extend Keycloak client
redirect_urisfor voting portal clients to includeVOTING_PORTAL_URL/*. - Normalize local dev URLs in portal
global-settings.jsonand.devcontainer/.env.developmentfromlocalhostto127.0.0.1for voting/ballot-verifier. - Update devcontainer auto-config script to invoke
step-cli(instead ofcli).
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/voting-portal/public/global-settings.json | Switch ballot verifier base URL to 127.0.0.1 for local dev. |
| packages/sequent-core/src/services/keycloak/realm.rs | Add voting portal URL pattern to Keycloak redirect URIs for voting portal clients. |
| packages/admin-portal/public/global-settings.json | Switch voting portal base URL to 127.0.0.1 for local dev. |
| .devcontainer/scripts/config-cli.sh | Use step-cli for devcontainer auto-configuration. |
| .devcontainer/.env.development | Update local dev URLs for ballot verifier and voting portal. |
Comments suppressed due to low confidence (1)
.devcontainer/scripts/config-cli.sh:19
- The script checks
$?after theifblock, so when required env vars are missing the last command is theecho, resulting in a false “configured successfully” message. Capture the exit code fromstep-cliexplicitly and treat the missing-env branch as a failure (or exit early).
step-cli step config \
--tenant-id "$SUPER_ADMIN_TENANT_ID" \
--endpoint-url "$HASURA_ENDPOINT" \
--keycloak-url "$KEYCLOAK_URL" \
--keycloak-user "$KEYCLOAK_ADMIN" \
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://github.com/sequentech/meta/issues/12279